This is a note to let you know that I've just added the patch titled
i40e: Fix sparse error: uninitialized symbol 'ring'
to the 5.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
i40e-fix-sparse-error-uninitialized-symbol-ring.patch
and it can be found in the queue-5.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From d6d04ee6d2c9bb5084c8f6074195d6aa0024e825 Mon Sep 17 00:00:00 2001
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
Date: Fri, 26 Mar 2021 19:43:41 +0100
Subject: i40e: Fix sparse error: uninitialized symbol 'ring'
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
commit d6d04ee6d2c9bb5084c8f6074195d6aa0024e825 upstream.
Init pointer with NULL in default switch case statement.
Previously the error was produced when compiling against sparse.
i40e_debugfs.c:582 i40e_dbg_dump_desc() error: uninitialized symbol 'ring'.
Fixes: 44ea803e2fa7 ("i40e: introduce new dump desc XDP command")
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
Tested-by: Dave Switzer <david.switzer@xxxxxxxxx>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -578,6 +578,9 @@ static void i40e_dbg_dump_desc(int cnt,
case RING_TYPE_XDP:
ring = kmemdup(vsi->xdp_rings[ring_id], sizeof(*ring), GFP_KERNEL);
break;
+ default:
+ ring = NULL;
+ break;
}
if (!ring)
return;
Patches currently in stable-queue which might be from arkadiusz.kubalewski@xxxxxxxxx are
queue-5.11/i40e-fix-sparse-errors-in-i40e_txrx.c.patch
queue-5.11/i40e-fix-sparse-warning-missing-error-code-err.patch
queue-5.11/i40e-fix-sparse-error-vsi-netdev-could-be-null.patch
queue-5.11/i40e-fix-sparse-error-uninitialized-symbol-ring.patch
