This is a note to let you know that I've just added the patch titled ethtool: fix incorrect datatype in set_eee ops to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ethtool-fix-incorrect-datatype-in-set_eee-ops.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 63cf32389925e234d166fb1a336b46de7f846003 Mon Sep 17 00:00:00 2001 From: Wong Vee Khee <vee.khee.wong@xxxxxxxxxxxxxxx> Date: Tue, 6 Apr 2021 21:17:30 +0800 Subject: ethtool: fix incorrect datatype in set_eee ops From: Wong Vee Khee <vee.khee.wong@xxxxxxxxxxxxxxx> commit 63cf32389925e234d166fb1a336b46de7f846003 upstream. The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool header file. Hence, we should use ethnl_update_u32() in set_eee ops. Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request") Cc: <stable@xxxxxxxxxxxxxxx> # 5.10.x Cc: Michal Kubecek <mkubecek@xxxxxxx> Signed-off-by: Wong Vee Khee <vee.khee.wong@xxxxxxxxxxxxxxx> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx> Reviewed-by: Michal Kubecek <mkubecek@xxxxxxx> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- net/ethtool/eee.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/ethtool/eee.c +++ b/net/ethtool/eee.c @@ -169,8 +169,8 @@ int ethnl_set_eee(struct sk_buff *skb, s ethnl_update_bool32(&eee.eee_enabled, tb[ETHTOOL_A_EEE_ENABLED], &mod); ethnl_update_bool32(&eee.tx_lpi_enabled, tb[ETHTOOL_A_EEE_TX_LPI_ENABLED], &mod); - ethnl_update_bool32(&eee.tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER], - &mod); + ethnl_update_u32(&eee.tx_lpi_timer, tb[ETHTOOL_A_EEE_TX_LPI_TIMER], + &mod); ret = 0; if (!mod) goto out_ops; Patches currently in stable-queue which might be from vee.khee.wong@xxxxxxxxxxxxxxx are queue-5.10/ethtool-fix-incorrect-datatype-in-set_eee-ops.patch