This is a note to let you know that I've just added the patch titled
NFSD: fix dest to src mount in inter-server COPY
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfsd-fix-dest-to-src-mount-in-inter-server-copy.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 614c9750173e412663728215152cc6d12bcb3425 Mon Sep 17 00:00:00 2001
From: Olga Kornievskaia <kolga@xxxxxxxxxx>
Date: Tue, 9 Mar 2021 09:41:14 -0500
Subject: NFSD: fix dest to src mount in inter-server COPY
From: Olga Kornievskaia <kolga@xxxxxxxxxx>
commit 614c9750173e412663728215152cc6d12bcb3425 upstream.
A cleanup of the inter SSC copy needs to call fput() of the source
file handle to make sure that file structure is freed as well as
drop the reference on the superblock to unmount the source server.
Fixes: 36e1e5ba90fb ("NFSD: Fix use-after-free warning when doing inter-server copy")
Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx>
Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
Tested-by: Dai Ngo <dai.ngo@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1299,7 +1299,7 @@ nfsd4_cleanup_inter_ssc(struct vfsmount
struct nfsd_file *dst)
{
nfs42_ssc_close(src->nf_file);
- /* 'src' is freed by nfsd4_do_async_copy */
+ fput(src->nf_file);
nfsd_file_put(dst);
mntput(ss_mnt);
}
Patches currently in stable-queue which might be from kolga@xxxxxxxxxx are
queue-5.10/nfsd-fix-dest-to-src-mount-in-inter-server-copy.patch
