This is a note to let you know that I've just added the patch titled ALSA: hda: Drop the BATCH workaround for AMD controllers to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-hda-drop-the-batch-workaround-for-amd-controllers.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 28e96c1693ec1cdc963807611f8b5ad400431e82 Mon Sep 17 00:00:00 2001 From: Takashi Iwai <tiwai@xxxxxxx> Date: Mon, 8 Mar 2021 17:07:26 +0100 Subject: ALSA: hda: Drop the BATCH workaround for AMD controllers From: Takashi Iwai <tiwai@xxxxxxx> commit 28e96c1693ec1cdc963807611f8b5ad400431e82 upstream. The commit c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)") introduced a few workarounds for the recent AMD HD-audio controller, and one of them is the forced BATCH PCM mode so that PulseAudio avoids the timer-based scheduling. This was thought to cover for some badly working applications, but this actually worsens for more others. In total, this wasn't a good idea to enforce it. This is a partial revert of the commit above for dropping the PCM BATCH enforcement part to recover from the regression again. Fixes: c02f77d32d2c ("ALSA: hda - Workaround for crackled sound on AMD controller (1022:1457)") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=195303 Cc: <stable@xxxxxxxxxxxxxxx> Link: https://lore.kernel.org/r/20210308160726.22930-1-tiwai@xxxxxxx Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- sound/pci/hda/hda_controller.c | 7 ------- 1 file changed, 7 deletions(-) --- a/sound/pci/hda/hda_controller.c +++ b/sound/pci/hda/hda_controller.c @@ -609,13 +609,6 @@ static int azx_pcm_open(struct snd_pcm_s 20, 178000000); - /* by some reason, the playback stream stalls on PulseAudio with - * tsched=1 when a capture stream triggers. Until we figure out the - * real cause, disable tsched mode by telling the PCM info flag. - */ - if (chip->driver_caps & AZX_DCAPS_AMD_WORKAROUND) - runtime->hw.info |= SNDRV_PCM_INFO_BATCH; - if (chip->align_buffer_size) /* constrain buffer sizes to be multiple of 128 bytes. This is more efficient in terms of memory Patches currently in stable-queue which might be from tiwai@xxxxxxx are queue-5.10/alsa-hda-avoid-spurious-unsol-event-handling-during-s3-s4.patch queue-5.10/alsa-hda-drop-the-batch-workaround-for-amd-controllers.patch queue-5.10/drm-amd-display-add-a-backlight-module-option.patch queue-5.10/alsa-usb-audio-fix-cannot-get-freq-eq-errors-on-dell-ae515-sound-bar.patch queue-5.10/alsa-hda-flush-pending-unsolicited-events-before-suspend.patch queue-5.10/alsa-usb-audio-fix-use-after-free-in-usb_audio_disconnect.patch queue-5.10/alsa-usb-add-plantronics-c320-m-usb-ctrl-msg-delay-quirk.patch queue-5.10/alsa-usb-audio-disable-usb-autosuspend-properly-in-setup_disable_autosuspend.patch queue-5.10/alsa-usb-audio-fix-null-ptr-dereference-in-usb_audio_probe.patch queue-5.10/alsa-hda-ca0132-add-sound-blasterx-ae-5-plus-support.patch queue-5.10/alsa-hda-conexant-add-quirk-for-mute-led-control-on-hp-zbook-g5.patch queue-5.10/alsa-hda-hdmi-cancel-pending-works-before-suspend.patch queue-5.10/alsa-usb-audio-apply-the-control-quirk-to-plantronics-headsets.patch