This is a note to let you know that I've just added the patch titled ALSA: hda: Avoid spurious unsol event handling during S3/S4 to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: alsa-hda-avoid-spurious-unsol-event-handling-during-s3-s4.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 5ff9dde42e8c72ed8102eb8cb62e03f9dc2103ab Mon Sep 17 00:00:00 2001 From: Takashi Iwai <tiwai@xxxxxxx> Date: Wed, 10 Mar 2021 12:28:08 +0100 Subject: ALSA: hda: Avoid spurious unsol event handling during S3/S4 From: Takashi Iwai <tiwai@xxxxxxx> commit 5ff9dde42e8c72ed8102eb8cb62e03f9dc2103ab upstream. When HD-audio bus receives unsolicited events during its system suspend/resume (S3 and S4) phase, the controller driver may still try to process events although the codec chips are already (or yet) powered down. This might screw up the codec communication, resulting in CORB/RIRB errors. Such events should be rather skipped, as the codec chip status such as the jack status will be fully refreshed at the system resume time. Since we're tracking the system suspend/resume state in codec power.power_state field, let's add the check in the common unsol event handler entry point to filter out such events. BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1182377 Tested-by: Abhishek Sahu <abhsahu@xxxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> # 183ab39eb0ea: ALSA: hda: Initialize power_state Link: https://lore.kernel.org/r/20210310112809.9215-3-tiwai@xxxxxxx Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- sound/pci/hda/hda_bind.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/sound/pci/hda/hda_bind.c +++ b/sound/pci/hda/hda_bind.c @@ -47,6 +47,10 @@ static void hda_codec_unsol_event(struct if (codec->bus->shutdown) return; + /* ignore unsol events during system suspend/resume */ + if (codec->core.dev.power.power_state.event != PM_EVENT_ON) + return; + if (codec->patch_ops.unsol_event) codec->patch_ops.unsol_event(codec, ev); } Patches currently in stable-queue which might be from tiwai@xxxxxxx are queue-5.10/alsa-hda-avoid-spurious-unsol-event-handling-during-s3-s4.patch queue-5.10/alsa-hda-drop-the-batch-workaround-for-amd-controllers.patch queue-5.10/drm-amd-display-add-a-backlight-module-option.patch queue-5.10/alsa-usb-audio-fix-cannot-get-freq-eq-errors-on-dell-ae515-sound-bar.patch queue-5.10/alsa-hda-flush-pending-unsolicited-events-before-suspend.patch queue-5.10/alsa-usb-audio-fix-use-after-free-in-usb_audio_disconnect.patch queue-5.10/alsa-usb-add-plantronics-c320-m-usb-ctrl-msg-delay-quirk.patch queue-5.10/alsa-usb-audio-disable-usb-autosuspend-properly-in-setup_disable_autosuspend.patch queue-5.10/alsa-usb-audio-fix-null-ptr-dereference-in-usb_audio_probe.patch queue-5.10/alsa-hda-ca0132-add-sound-blasterx-ae-5-plus-support.patch queue-5.10/alsa-hda-conexant-add-quirk-for-mute-led-control-on-hp-zbook-g5.patch queue-5.10/alsa-hda-hdmi-cancel-pending-works-before-suspend.patch queue-5.10/alsa-usb-audio-apply-the-control-quirk-to-plantronics-headsets.patch