This is a note to let you know that I've just added the patch titled
media: mceusb: Fix potential out-of-bounds shift
to the 5.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
media-mceusb-fix-potential-out-of-bounds-shift.patch
and it can be found in the queue-5.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 1b43bad31fb0e00f45baf5b05bd21eb8d8ce7f58 Mon Sep 17 00:00:00 2001
From: James Reynolds <jr@xxxxxxxxxx>
Date: Tue, 22 Dec 2020 13:07:04 +0100
Subject: media: mceusb: Fix potential out-of-bounds shift
From: James Reynolds <jr@xxxxxxxxxx>
commit 1b43bad31fb0e00f45baf5b05bd21eb8d8ce7f58 upstream.
When processing a MCE_RSP_GETPORTSTATUS command, the bit index to set in
ir->txports_cabled comes from response data, and isn't validated.
As ir->txports_cabled is a u8, nothing should be done if the bit index
is greater than 7.
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: syzbot+ec3b3128c576e109171d@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: James Reynolds <jr@xxxxxxxxxx>
Signed-off-by: Sean Young <sean@xxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/media/rc/mceusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/rc/mceusb.c
+++ b/drivers/media/rc/mceusb.c
@@ -1169,7 +1169,7 @@ static void mceusb_handle_command(struct
switch (subcmd) {
/* the one and only 5-byte return value command */
case MCE_RSP_GETPORTSTATUS:
- if (buf_in[5] == 0)
+ if (buf_in[5] == 0 && *hi < 8)
ir->txports_cabled |= 1 << *hi;
break;
Patches currently in stable-queue which might be from jr@xxxxxxxxxx are
queue-5.11/media-mceusb-fix-potential-out-of-bounds-shift.patch
