This is a note to let you know that I've just added the patch titled
ALSA: hda/hdmi: Drop bogus check at closing a stream
to the 5.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-hda-hdmi-drop-bogus-check-at-closing-a-stream.patch
and it can be found in the queue-5.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 056a3da5d07fc5d3ceacfa2cdf013c9d8df630bd Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@xxxxxxx>
Date: Thu, 11 Feb 2021 09:31:39 +0100
Subject: ALSA: hda/hdmi: Drop bogus check at closing a stream
From: Takashi Iwai <tiwai@xxxxxxx>
commit 056a3da5d07fc5d3ceacfa2cdf013c9d8df630bd upstream.
Some users reported the kernel WARNING with stack traces from
hdmi_pcm_close(), and it's the line checking the per_cvt->assigned
flag. This used to be a valid check in the past because the flag was
turned on/off only at opening and closing a PCM stream. Meanwhile,
since the introduction of the silent-stream mode, this flag may be
turned on/off at the monitor connection/disconnection time, which
isn't always associated with the PCM open/close. Hence this may lead
to the inconsistent per_cvt->assigned flag at closing.
As the check itself became almost useless and confuses users as if it
were a serious problem, just drop the check.
Fixes: b1a5039759cb ("ALSA: hda/hdmi: fix silent stream for first playback to DP")
Cc: <stable@xxxxxxxxxxxxxxx>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210987
Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20210211083139.29531-1-tiwai@xxxxxxx
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
sound/pci/hda/patch_hdmi.c | 1 -
1 file changed, 1 deletion(-)
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2130,7 +2130,6 @@ static int hdmi_pcm_close(struct hda_pcm
goto unlock;
}
per_cvt = get_cvt(spec, cvt_idx);
- snd_BUG_ON(!per_cvt->assigned);
per_cvt->assigned = 0;
hinfo->nid = 0;
Patches currently in stable-queue which might be from tiwai@xxxxxxx are
queue-5.11/alsa-usb-audio-correct-document-for-snd_usb_endpoint_free_all.patch
queue-5.11/alsa-pcm-don-t-call-sync_stop-if-it-hasn-t-been-stopped.patch
queue-5.11/alsa-usb-audio-fix-pcm-buffer-allocation-in-non-vmalloc-mode.patch
queue-5.11/alsa-usb-audio-handle-invalid-running-state-at-releasing-ep.patch
queue-5.11/alsa-usb-audio-more-strict-state-change-in-ep.patch
queue-5.11/alsa-hda-add-another-cometlake-h-pci-id.patch
queue-5.11/alsa-hda-realtek-quirk-for-hp-spectre-x360-14-amp-setup.patch
queue-5.11/alsa-pcm-assure-sync-with-the-pending-stop-operation-at-suspend.patch
queue-5.11/alsa-fireface-fix-to-parse-sync-status-register-of-latter-protocol.patch
queue-5.11/alsa-hda-realtek-modify-eapd-in-the-alc886.patch
queue-5.11/alsa-pcm-call-sync_stop-at-disconnection.patch
queue-5.11/alsa-hda-hdmi-drop-bogus-check-at-closing-a-stream.patch
queue-5.11/asoc-siu-fix-build-error-by-a-wrong-const-prefix.patch
queue-5.11/alsa-usb-audio-don-t-avoid-stopping-the-stream-at-disconnection.patch
queue-5.11/alsa-usb-audio-add-implicit-fb-quirk-for-boss-gp-10.patch
