This is a note to let you know that I've just added the patch titled
ACPI: configfs: add missing check after configfs_register_default_group()
to the 5.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-configfs-add-missing-check-after-configfs_register_default_group.patch
and it can be found in the queue-5.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 67e40054de86aae520ddc2a072d7f6951812a14f Mon Sep 17 00:00:00 2001
From: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
Date: Fri, 15 Jan 2021 10:22:50 +0800
Subject: ACPI: configfs: add missing check after configfs_register_default_group()
From: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
commit 67e40054de86aae520ddc2a072d7f6951812a14f upstream.
A list_add corruption is reported by Hulk Robot like this:
==============
list_add corruption.
Call Trace:
link_obj+0xc0/0x1c0
link_group+0x21/0x140
configfs_register_subsystem+0xdb/0x380
acpi_configfs_init+0x25/0x1000 [acpi_configfs]
do_one_initcall+0x149/0x820
do_init_module+0x1ef/0x720
load_module+0x35c8/0x4380
__do_sys_finit_module+0x10d/0x1a0
do_syscall_64+0x34/0x80
It's because of the missing check after configfs_register_default_group,
where configfs_unregister_subsystem should be called once failure.
Fixes: 612bd01fc6e0 ("ACPI: add support for loading SSDTs via configfs")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Suggested-by: Hanjun Guo <guohanjun@xxxxxxxxxx>
Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
Cc: 4.10+ <stable@xxxxxxxxxxxxxxx> # 4.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/acpi/acpi_configfs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- a/drivers/acpi/acpi_configfs.c
+++ b/drivers/acpi/acpi_configfs.c
@@ -268,7 +268,12 @@ static int __init acpi_configfs_init(voi
acpi_table_group = configfs_register_default_group(root, "table",
&acpi_tables_type);
- return PTR_ERR_OR_ZERO(acpi_table_group);
+ if (IS_ERR(acpi_table_group)) {
+ configfs_unregister_subsystem(&acpi_configfs);
+ return PTR_ERR(acpi_table_group);
+ }
+
+ return 0;
}
module_init(acpi_configfs_init);
Patches currently in stable-queue which might be from miaoqinglang@xxxxxxxxxx are
queue-5.11/drm-tegra-fix-reference-leak-when-pm_runtime_get_syn.patch
queue-5.11/drm-lima-fix-reference-leak-in-lima_pm_busy.patch
queue-5.11/acpi-configfs-add-missing-check-after-configfs_register_default_group.patch
queue-5.11/drm-rcar-du-fix-pm-reference-leak-in-rcar_cmm_enable.patch
