Patch "objtool: Fix ".cold" section suffix check for newer versions of GCC" has been added to the 5.11-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    objtool: Fix ".cold" section suffix check for newer versions of GCC

to the 5.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     objtool-fix-.cold-section-suffix-check-for-newer-ver.patch
and it can be found in the queue-5.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 492a7b70baa790b5a6cb790c3aafcd097d0b076a
Author: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Date:   Thu Jan 21 15:29:19 2021 -0600

    objtool: Fix ".cold" section suffix check for newer versions of GCC
    
    [ Upstream commit 34ca59e109bdf69704c33b8eeffaa4c9f71076e5 ]
    
    With my version of GCC 9.3.1 the ".cold" subfunctions no longer have a
    numbered suffix, so the trailing period is no longer there.
    
    Presumably this doesn't yet trigger a user-visible bug since most of the
    subfunction detection logic is duplicated.   I only found it when
    testing vmlinux.o validation.
    
    Fixes: 54262aa28301 ("objtool: Fix sibling call detection")
    Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/ca0b5a57f08a2fbb48538dd915cc253b5edabb40.1611263461.git.jpoimboe@xxxxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 48e22e3c6f186..dc24aac08edd6 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -850,8 +850,8 @@ static int add_jump_destinations(struct objtool_file *file)
 			 * case where the parent function's only reference to a
 			 * subfunction is through a jump table.
 			 */
-			if (!strstr(insn->func->name, ".cold.") &&
-			    strstr(insn->jump_dest->func->name, ".cold.")) {
+			if (!strstr(insn->func->name, ".cold") &&
+			    strstr(insn->jump_dest->func->name, ".cold")) {
 				insn->func->cfunc = insn->jump_dest->func;
 				insn->jump_dest->func->pfunc = insn->func;
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux