Patch "power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression" has been added to the 5.11-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression

to the 5.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     power-supply-cpcap-add-missing-irqf_oneshot-to-fix-r.patch
and it can be found in the queue-5.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit a7b5851d7099d181a1e1c46211dc7d0aa7be2778
Author: Tony Lindgren <tony@xxxxxxxxxxx>
Date:   Wed Dec 30 12:19:11 2020 +0200

    power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression
    
    [ Upstream commit e62333e26be649bfc3c167b9f2bbca38b92332c5 ]
    
    Commit 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT") started causing
    errors loading phy-cpcap-usb driver:
    
    cpcap_battery cpcap_battery.0: failed to register power supply
    genirq: Flags mismatch irq 211. 00002080 (se0conn) vs. 00000080 (se0conn)
    cpcap-usb-phy cpcap-usb-phy.0: could not get irq se0conn: -16
    
    Let's fix this by adding the missing IRQF_ONESHOT to also cpcap-battery
    and cpcap-charger drivers.
    
    Fixes: 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT")
    Reported-by: Merlijn Wajer <merlijn@xxxxxxxxxx>
    Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 295611b3b15e9..7a974b5bd9dd1 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -666,7 +666,7 @@ static int cpcap_battery_init_irq(struct platform_device *pdev,
 
 	error = devm_request_threaded_irq(ddata->dev, irq, NULL,
 					  cpcap_battery_irq_thread,
-					  IRQF_SHARED,
+					  IRQF_SHARED | IRQF_ONESHOT,
 					  name, ddata);
 	if (error) {
 		dev_err(ddata->dev, "could not get irq %s: %i\n",
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index c0d452e3dc8b0..804ac7f84c301 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -708,7 +708,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
 
 	error = devm_request_threaded_irq(ddata->dev, irq, NULL,
 					  cpcap_charger_irq_thread,
-					  IRQF_SHARED,
+					  IRQF_SHARED | IRQF_ONESHOT,
 					  name, ddata);
 	if (error) {
 		dev_err(ddata->dev, "could not get irq %s: %i\n",



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux