This is a note to let you know that I've just added the patch titled
net: flow_offload: Fix memory leak for indirect flow block
to the 5.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-flow_offload-fix-memory-leak-for-indirect-flow-block.patch
and it can be found in the queue-5.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Sat Dec 19 11:38:44 AM CET 2020
From: Chris Mi <cmi@xxxxxxxxxx>
Date: Tue, 8 Dec 2020 10:48:35 +0800
Subject: net: flow_offload: Fix memory leak for indirect flow block
From: Chris Mi <cmi@xxxxxxxxxx>
[ Upstream commit 5137d303659d8c324e67814b1cc2e1bc0c0d9836 ]
The offending commit introduces a cleanup callback that is invoked
when the driver module is removed to clean up the tunnel device
flow block. But it returns on the first iteration of the for loop.
The remaining indirect flow blocks will never be freed.
Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
CC: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Signed-off-by: Chris Mi <cmi@xxxxxxxxxx>
Reviewed-by: Roi Dayan <roid@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/core/flow_offload.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/net/core/flow_offload.c
+++ b/net/core/flow_offload.c
@@ -381,10 +381,8 @@ static void __flow_block_indr_cleanup(vo
list_for_each_entry_safe(this, next, &flow_block_indr_list, indr.list) {
if (this->release == release &&
- this->indr.cb_priv == cb_priv) {
+ this->indr.cb_priv == cb_priv)
list_move(&this->indr.list, cleanup_list);
- return;
- }
}
}
Patches currently in stable-queue which might be from cmi@xxxxxxxxxx are
queue-5.9/net-flow_offload-fix-memory-leak-for-indirect-flow-block.patch
