This is a note to let you know that I've just added the patch titled
io_uring: don't double complete failed reissue request
to the 5.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
io_uring-don-t-double-complete-failed-reissue-request.patch
and it can be found in the queue-5.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From c993df5a688975bf9ce899706ca13d2bc8d6be25 Mon Sep 17 00:00:00 2001
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Tue, 17 Nov 2020 07:59:16 -0700
Subject: io_uring: don't double complete failed reissue request
From: Jens Axboe <axboe@xxxxxxxxx>
commit c993df5a688975bf9ce899706ca13d2bc8d6be25 upstream.
Zorro reports that an xfstest test case is failing, and it turns out that
for the reissue path we can potentially issue a double completion on the
request for the failure path. There's an issue around the retry as well,
but for now, at least just make sure that we handle the error path
correctly.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")
Reported-by: Zorro Lang <zlang@xxxxxxxxxx>
Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/io_uring.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2359,7 +2359,6 @@ static bool io_resubmit_prep(struct io_k
}
end_req:
req_set_fail_links(req);
- io_req_complete(req, ret);
return false;
}
#endif
Patches currently in stable-queue which might be from axboe@xxxxxxxxx are
queue-5.9/io_uring-don-t-double-complete-failed-reissue-request.patch
queue-5.9/mm-never-attempt-async-page-lock-if-we-ve-transferred-data-already.patch
queue-5.9/s390-dasd-fix-null-pointer-dereference-for-erp-requests.patch
queue-5.9/usb-dwc2-avoid-leaving-the-error_debugfs-label-unuse.patch
queue-5.9/blk-cgroup-fix-a-hd_struct-leak-in-blkcg_fill_root_iostats.patch
