This is a note to let you know that I've just added the patch titled
thunderbolt: Fix memory leak if ida_simple_get() fails in enumerate_services()
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
thunderbolt-fix-memory-leak-if-ida_simple_get-fails-in-enumerate_services.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From a663e0df4a374b8537562a44d1cecafb472cd65b Mon Sep 17 00:00:00 2001
From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Date: Wed, 7 Oct 2020 17:06:17 +0300
Subject: thunderbolt: Fix memory leak if ida_simple_get() fails in enumerate_services()
From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
commit a663e0df4a374b8537562a44d1cecafb472cd65b upstream.
The svc->key field is not released as it should be if ida_simple_get()
fails so fix that.
Fixes: 9aabb68568b4 ("thunderbolt: Fix to check return value of ida_simple_get")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/thunderbolt/xdomain.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/thunderbolt/xdomain.c
+++ b/drivers/thunderbolt/xdomain.c
@@ -830,6 +830,7 @@ static void enumerate_services(struct tb
id = ida_simple_get(&xd->service_ids, 0, 0, GFP_KERNEL);
if (id < 0) {
+ kfree(svc->key);
kfree(svc);
break;
}
Patches currently in stable-queue which might be from mika.westerberg@xxxxxxxxxxxxxxx are
queue-5.4/pinctrl-intel-set-default-bias-in-case-no-particular.patch
queue-5.4/thunderbolt-add-the-missed-ida_simple_remove-in-ring_request_msix.patch
queue-5.4/thunderbolt-fix-memory-leak-if-ida_simple_get-fails-in-enumerate_services.patch
