This is a note to let you know that I've just added the patch titled
Revert "block: ratelimit handle_bad_sector() message"
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-block-ratelimit-handle_bad_sector-message.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 2a2b435ca40a18fe9fa663f371988f2d4c468d8b Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 1 Nov 2020 11:42:18 +0100
Subject: Revert "block: ratelimit handle_bad_sector() message"
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
This reverts commit f86b9bf6228bb334fe1addcd566a658ecbd08f7e which is
commit f4ac712e4fe009635344b9af5d890fe25fcc8c0d upstream.
Jari Ruusu writes:
Above change "block: ratelimit handle_bad_sector() message"
upstream commit f4ac712e4fe009635344b9af5d890fe25fcc8c0d
in 4.19.154 kernel is not completely OK.
Removing casts from arguments 4 and 5 produces these compile warnings:
...
For 64 bit systems it is only compile time cosmetic warning. For 32 bit
system + CONFIG_LBDAF=n it introduces bugs: output formats are "%llu" and
passed parameters are 32 bits. That is not OK.
Upstream kernels have hardcoded 64 bit sector_t. In older stable trees
sector_t can be either 64 or 32 bit. In other words, backport of above patch
needs to keep those original casts.
And Tetsuo Handa writes:
Indeed, commit f4ac712e4fe00963 ("block: ratelimit handle_bad_sector() message")
depends on commit 72deb455b5ec619f ("block: remove CONFIG_LBDAF") which was merged
into 5.2 kernel.
So let's revert it.
Reported-by: Jari Ruusu <jariruusu@xxxxxxxxxxxxxxxxxxxxx>
Reported-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Sasha Levin <sashal@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
block/blk-core.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2127,10 +2127,11 @@ static void handle_bad_sector(struct bio
{
char b[BDEVNAME_SIZE];
- pr_info_ratelimited("attempt to access beyond end of device\n"
- "%s: rw=%d, want=%llu, limit=%llu\n",
- bio_devname(bio, b), bio->bi_opf,
- bio_end_sector(bio), maxsector);
+ printk(KERN_INFO "attempt to access beyond end of device\n");
+ printk(KERN_INFO "%s: rw=%d, want=%Lu, limit=%Lu\n",
+ bio_devname(bio, b), bio->bi_opf,
+ (unsigned long long)bio_end_sector(bio),
+ (long long)maxsector);
}
#ifdef CONFIG_FAIL_MAKE_REQUEST
Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are
queue-4.19/cxgb4-set-up-filter-action-after-rewrites.patch
queue-4.19/arm64-link-with-z-norelro-regardless-of-config_relocatable.patch
queue-4.19/fscrypt-only-set-dentry_operations-on-ciphertext-dentries.patch
queue-4.19/objtool-support-clang-non-section-symbols-in-orc-generation.patch
queue-4.19/fscrypt-clean-up-and-improve-dentry-revalidation.patch
queue-4.19/evm-check-size-of-security.evm-before-using-it.patch
queue-4.19/fscrypt-fix-race-allowing-rename-and-link-of-ciphertext-dentries.patch
queue-4.19/chelsio-chtls-fix-memory-leaks-in-cpl-handlers.patch
queue-4.19/mlxsw-core-fix-memory-leak-on-module-removal.patch
queue-4.19/gtp-fix-an-use-before-init-in-gtp_newlink.patch
queue-4.19/tipc-fix-memory-leak-caused-by-tipc_buf_append.patch
queue-4.19/fs-fscrypt-clear-dcache_encrypted_name-when-unaliasing-directory.patch
queue-4.19/fscrypt-fix-race-where-lookup-marks-plaintext-dentry-as-ciphertext.patch
queue-4.19/bpf-fix-comment-for-helper-bpf_current_task_under_cgroup.patch
queue-4.19/fscrypt-return-exdev-for-incompatible-rename-or-link-into-encrypted-dir.patch
queue-4.19/scripts-setlocalversion-make-git-describe-output-more-reliable.patch
queue-4.19/p54-avoid-accessing-the-data-mapped-to-streaming-dma.patch
queue-4.19/r8169-fix-issue-with-forced-threading-in-combination-with-shared-interrupts.patch
queue-4.19/arch-x86-amd-ibs-fix-re-arming-ibs-fetch.patch
queue-4.19/fuse-fix-page-dereference-after-free.patch
queue-4.19/ravb-fix-bit-fields-checking-in-ravb_hwtstamp_get.patch
queue-4.19/revert-block-ratelimit-handle_bad_sector-message.patch
queue-4.19/rdma-addr-fix-race-with-netevent_callback-rdma_addr_cancel.patch
queue-4.19/chelsio-chtls-fix-deadlock-issue.patch
queue-4.19/x86-xen-disable-firmware-first-mode-for-correctable-memory-errors.patch
queue-4.19/serial-pl011-fix-lockdep-splat-when-handling-magic-sysrq-interrupt.patch
queue-4.19/ata-sata_rcar-fix-dma-boundary-mask.patch
queue-4.19/chelsio-chtls-fix-tls-record-info-to-user.patch
queue-4.19/x86-pci-fix-intel_mid_pci.c-build-error-when-acpi-is-not-enabled.patch
queue-4.19/netem-fix-zero-division-in-tabledist.patch
queue-4.19/tcp-prevent-low-rmem-stalls-with-so_rcvlowat.patch
queue-4.19/cxl-rework-error-message-for-incompatible-slots.patch
queue-4.19/mtd-lpddr-fix-bad-logic-in-print_drs_error.patch
queue-4.19/efivarfs-replace-invalid-slashes-with-exclamation-marks-in-dentries.patch
queue-4.19/arm64-run-arch_workaround_1-enabling-code-on-all-cpus.patch
