This is a note to let you know that I've just added the patch titled erofs: avoid duplicated permission check for "trusted." xattrs to the 5.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: erofs-avoid-duplicated-permission-check-for-trusted.-xattrs.patch and it can be found in the queue-5.8 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From d578b46db69d125a654f509bdc9091d84e924dc8 Mon Sep 17 00:00:00 2001 From: Gao Xiang <hsiangkao@xxxxxxxxxx> Date: Tue, 11 Aug 2020 15:00:20 +0800 Subject: erofs: avoid duplicated permission check for "trusted." xattrs From: Gao Xiang <hsiangkao@xxxxxxxxxx> commit d578b46db69d125a654f509bdc9091d84e924dc8 upstream. Don't recheck it since xattr_permission() already checks CAP_SYS_ADMIN capability. Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") Reported-by: Hongyu Jin <hongyu.jin@xxxxxxxxxx> [ Gao Xiang: since it could cause some complex Android overlay permission issue as well on android-5.4+, it'd be better to backport to 5.4+ rather than pure cleanup on mainline. ] Cc: <stable@xxxxxxxxxxxxxxx> # 5.4+ Link: https://lore.kernel.org/r/20200811070020.6339-1-hsiangkao@xxxxxxxxxx Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/erofs/xattr.c | 2 -- 1 file changed, 2 deletions(-) --- a/fs/erofs/xattr.c +++ b/fs/erofs/xattr.c @@ -473,8 +473,6 @@ static int erofs_xattr_generic_get(const return -EOPNOTSUPP; break; case EROFS_XATTR_INDEX_TRUSTED: - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; break; case EROFS_XATTR_INDEX_SECURITY: break; Patches currently in stable-queue which might be from hsiangkao@xxxxxxxxxx are queue-5.8/erofs-avoid-duplicated-permission-check-for-trusted.-xattrs.patch