This is a note to let you know that I've just added the patch titled
[PATCH stable 5.9 23/25] net/smc: fix invalid return code in smcd_new_buf_create()
to the 5.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-smc-fix-invalid-return-code-in-smcd_new_buf_create.patch
and it can be found in the queue-5.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Sat Oct 31 09:05:46 AM CET 2020
From: Karsten Graul <kgraul@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2020 19:43:29 +0200
Subject: [PATCH stable 5.9 23/25] net/smc: fix invalid return code in smcd_new_buf_create()
From: Karsten Graul <kgraul@xxxxxxxxxxxxx>
[ Upstream commit 6b1bbf94ab369d97ed3bdaa561521a52c27ef619 ]
smc_ism_register_dmb() returns error codes set by the ISM driver which
are not guaranteed to be negative or in the errno range. Such values
would not be handled by ERR_PTR() and finally the return code will be
used as a memory address.
Fix that by using a valid negative errno value with ERR_PTR().
Fixes: 72b7f6c48708 ("net/smc: unique reason code for exceeded max dmb count")
Signed-off-by: Karsten Graul <kgraul@xxxxxxxxxxxxx>
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/smc/smc_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/net/smc/smc_core.c
+++ b/net/smc/smc_core.c
@@ -1616,7 +1616,8 @@ static struct smc_buf_desc *smcd_new_buf
rc = smc_ism_register_dmb(lgr, bufsize, buf_desc);
if (rc) {
kfree(buf_desc);
- return (rc == -ENOMEM) ? ERR_PTR(-EAGAIN) : ERR_PTR(rc);
+ return (rc == -ENOMEM) ? ERR_PTR(-EAGAIN) :
+ ERR_PTR(-EIO);
}
buf_desc->pages = virt_to_page(buf_desc->cpu_addr);
/* CDC header stored in buf. So, pretend it was smaller */
Patches currently in stable-queue which might be from kgraul@xxxxxxxxxxxxx are
queue-5.9/net-smc-fix-invalid-return-code-in-smcd_new_buf_create.patch
queue-5.9/net-smc-fix-suppressed-return-code.patch
