This is a note to let you know that I've just added the patch titled
[PATCH stable 5.8 25/25] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()
to the 5.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-sched-act_gate-unlock-tcfa_lock-in-tc_setup_flow_action.patch
and it can be found in the queue-5.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Sat Oct 24 10:56:27 AM CEST 2020
From: Guillaume Nault <gnault@xxxxxxxxxx>
Date: Tue, 20 Oct 2020 17:34:31 +0200
Subject: [PATCH stable 5.8 25/25] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()
From: Guillaume Nault <gnault@xxxxxxxxxx>
[ Upstream commit b130762161374b1ef31549bef8ebd4abeb998d94 ]
We need to jump to the "err_out_locked" label when
tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits
with ->tcfa_lock still held.
Fixes: d29bdd69ecdd ("net: schedule: add action gate offloading")
Signed-off-by: Guillaume Nault <gnault@xxxxxxxxxx>
Acked-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>
Link: https://lore.kernel.org/r/12f60e385584c52c22863701c0185e40ab08a7a7.1603207948.git.gnault@xxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/sched/cls_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -3707,7 +3707,7 @@ int tc_setup_flow_action(struct flow_act
entry->gate.num_entries = tcf_gate_num_entries(act);
err = tcf_gate_get_entries(entry, act);
if (err)
- goto err_out;
+ goto err_out_locked;
} else {
err = -EOPNOTSUPP;
goto err_out_locked;
Patches currently in stable-queue which might be from gnault@xxxxxxxxxx are
queue-5.8/net-sched-act_gate-unlock-tcfa_lock-in-tc_setup_flow_action.patch
