This is a note to let you know that I've just added the patch titled ibmveth: Switch order of ibmveth_helper calls. to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ibmveth-switch-order-of-ibmveth_helper-calls.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From foo@baz Sat Oct 17 01:00:22 PM CEST 2020 From: David Wilder <dwilder@xxxxxxxxxx> Date: Tue, 13 Oct 2020 16:20:13 -0700 Subject: ibmveth: Switch order of ibmveth_helper calls. From: David Wilder <dwilder@xxxxxxxxxx> [ Upstream commit 5ce9ad815a296374ca21f43f3b1ab5083d202ee1 ] ibmveth_rx_csum_helper() must be called after ibmveth_rx_mss_helper() as ibmveth_rx_csum_helper() may alter ip and tcp checksum values. Fixes: 66aa0678efc2 ("ibmveth: Support to enable LSO/CSO for Trunk VEA.") Signed-off-by: David Wilder <dwilder@xxxxxxxxxx> Reviewed-by: Thomas Falcon <tlfalcon@xxxxxxxxxxxxx> Reviewed-by: Cristobal Forno <cris.forno@xxxxxxx> Reviewed-by: Pradeep Satyanarayana <pradeeps@xxxxxxxxxxxxxxxxxx> Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/ethernet/ibm/ibmveth.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1366,16 +1366,16 @@ static int ibmveth_poll(struct napi_stru skb_put(skb, length); skb->protocol = eth_type_trans(skb, netdev); - if (csum_good) { - skb->ip_summed = CHECKSUM_UNNECESSARY; - ibmveth_rx_csum_helper(skb, adapter); - } - if (length > netdev->mtu + ETH_HLEN) { ibmveth_rx_mss_helper(skb, mss, lrg_pkt); adapter->rx_large_packets++; } + if (csum_good) { + skb->ip_summed = CHECKSUM_UNNECESSARY; + ibmveth_rx_csum_helper(skb, adapter); + } + napi_gro_receive(napi, skb); /* send it up */ netdev->stats.rx_packets++; Patches currently in stable-queue which might be from dwilder@xxxxxxxxxx are queue-4.14/ibmveth-identify-ingress-large-send-packets.patch queue-4.14/ibmveth-switch-order-of-ibmveth_helper-calls.patch