On Tue, Sep 29, 2020 at 11:36:33AM -0400, Theodore Y. Ts'o wrote:
On Mon, Sep 28, 2020 at 05:52:43PM -0400, Sasha Levin wrote:
On Mon, Sep 28, 2020 at 03:27:35PM -0400, Theodore Y. Ts'o wrote:
> On Sun, Sep 27, 2020 at 01:54:53PM -0400, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > ext4: make dioread_nolock the default
> >
> > to the 5.4-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > ext4-make-dioread_nolock-the-default.patch
> > and it can be found in the queue-5.4 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@xxxxxxxxxxxxxxx> know about it.
>
> Please see the discussion about a week and half ago (Septeber 17th)
> where Eric Biggers point out this was not a good idea to backport this
> commit. I'm guessing this just popped out again through your
> algorithm and the commit wasn't put on a blocked list?
Looks like I tried to drop it from the wrong branch the first time.
Sorry about that and thanks for pointing it out.
You'll drop this from all of your pending stable kernel versions
branch, right? Thanks!!
Yup!
But just FYI, this AUTOSEL series wasn't really stuff picked by the bot
but instead it was an audit of patches carried by downstream kernels on
top of the 5.4 LTS.
So it looks like folks are picking it up for one reason or another...
Googling this patch points to articles such as
https://www.percona.com/blog/2019/11/12/watch-out-for-disk-i-o-performance-issues-when-running-ext4/
which suggest using dioread_nolock to avoid a performance regression, so
it looks like some kernels are picking up this patch up.
--
Thanks,
Sasha
