This is a note to let you know that I've just added the patch titled ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm() to the 5.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: arm-omap2-fix-an-is_err-vs-null-check-in-_get_pwrdm.patch and it can be found in the queue-5.8 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. commit f03b6fa653b98c65536b12f8b7597aee9d300147 Author: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> Date: Fri Jul 24 11:54:30 2020 +0800 ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm() [ Upstream commit a58cfdba2039ff2d5758840e97a23a2dedecf1e8 ] The of_clk_get() function returns error pointers, it never returns NULL. Fixes: 4ea3711aece4 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc") Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c index 54aff33e55e6e..bfa5e1b8dba7f 100644 --- a/arch/arm/mach-omap2/omap-iommu.c +++ b/arch/arm/mach-omap2/omap-iommu.c @@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev) return pwrdm; clk = of_clk_get(dev->of_node->parent, 0); - if (!clk) { + if (IS_ERR(clk)) { dev_err(dev, "no fck found\n"); return NULL; }