On Fri, Sep 11, 2020 at 01:12:50PM +0530, Vasundhara Volam wrote: > On Fri, Sep 11, 2020 at 1:02 PM <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > This is a note to let you know that I've just added the patch titled > > > > bnxt_en: Check for zero dir entries in NVRAM. > > > > to the 5.8-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > bnxt_en-check-for-zero-dir-entries-in-nvram.patch > > and it can be found in the queue-5.8 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > From foo@baz Fri Sep 11 09:06:45 AM CEST 2020 > > From: Vasundhara Volam <vasundhara-v.volam@xxxxxxxxxxxx> > > Date: Wed, 26 Aug 2020 01:08:33 -0400 > > Subject: bnxt_en: Check for zero dir entries in NVRAM. > > > > From: Vasundhara Volam <vasundhara-v.volam@xxxxxxxxxxxx> > > > > [ Upstream commit dbbfa96ad920c50d58bcaefa57f5f33ceef9d00e ] > > > > If firmware goes into unstable state, HWRM_NVM_GET_DIR_INFO firmware > > command may return zero dir entries. Return error in such case to > > avoid zero length dma buffer request. > > > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") > > Signed-off-by: Vasundhara Volam <vasundhara-v.volam@xxxxxxxxxxxx> > > Signed-off-by: Michael Chan <michael.chan@xxxxxxxxxxxx> > > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > --- > > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > > @@ -2266,6 +2266,9 @@ static int bnxt_get_nvram_directory(stru > > if (!dir_entries || !entry_length) > > return -EIO; > > > > + if (!dir_entries || !entry_length) > > + return -EIO; > > + > Looks like patch is getting applied second time to 5.8. Could you please check? Yes, I realized this right after sending it out, I've now dropped it, thanks for the quick review! greg k-h