Patch "media: i2c: imx214: select V4L2_FWNODE" has been added to the 5.8-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    media: i2c: imx214: select V4L2_FWNODE

to the 5.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     media-i2c-imx214-select-v4l2_fwnode.patch
and it can be found in the queue-5.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit aba29d9058bad6040d6bc30b3ec97ec7626f7eb4
Author: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Date:   Mon Jun 22 18:43:52 2020 +0200

    media: i2c: imx214: select V4L2_FWNODE
    
    [ Upstream commit bca82e3557ee1fbfbdacb09033a2d81ac76c86eb ]
    
    After the recent conversion of the media build infrastructure to select
    V4L2 components instead of depending on their presence, which took place
    in:
    32a363d0b0b14 ("media: Kconfig files: use select for V4L2 subdevs and MC")
    
    imx214 stands out as being the (only?) media I2C driver that still depends
    on a V4L2 core symbol instead of selecting it.
    
    This confuses the build system which claims it has detected a circular
    dependency when other drivers select the same symbol as the imx214
    driver does.
    
    drivers/media/i2c/Kconfig:728:error: recursive dependency detected!
    drivers/media/i2c/Kconfig:728:  symbol VIDEO_IMX214 depends on V4L2_FWNODE
    drivers/media/v4l2-core/Kconfig:71:     symbol V4L2_FWNODE is selected by VIDEO_BCM2835_UNICAM
    drivers/media/platform/bcm2835/Kconfig:3:       symbol VIDEO_BCM2835_UNICAM depends on VIDEO_V4L2_SUBDEV_API
    drivers/media/v4l2-core/Kconfig:19:     symbol VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER
    drivers/media/Kconfig:168:      symbol MEDIA_CONTROLLER is selected by VIDEO_IMX214
    
    Fix this by making the imx214 driver select V4L2_FWNODE instead of
    depending on it and align it with all the other drivers.
    
    Fixes: 32a363d0b0b14 ("media: Kconfig files: use select for V4L2 subdevs and MC")
    Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
    Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
    Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index da11036ad804d..6b1a6851ccb0b 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -728,7 +728,7 @@ config VIDEO_HI556
 config VIDEO_IMX214
 	tristate "Sony IMX214 sensor support"
 	depends on GPIOLIB && I2C && VIDEO_V4L2
-	depends on V4L2_FWNODE
+	select V4L2_FWNODE
 	select MEDIA_CONTROLLER
 	select VIDEO_V4L2_SUBDEV_API
 	select REGMAP_I2C



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux