This is a note to let you know that I've just added the patch titled
gfs2: Fix refcount leak in gfs2_glock_poke
to the 5.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
gfs2-fix-refcount-leak-in-gfs2_glock_poke.patch
and it can be found in the queue-5.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From c07bfb4d8fa1ee11c6d18b093d0bb6c8832d3626 Mon Sep 17 00:00:00 2001
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Mon, 27 Jul 2020 19:18:57 +0200
Subject: gfs2: Fix refcount leak in gfs2_glock_poke
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
commit c07bfb4d8fa1ee11c6d18b093d0bb6c8832d3626 upstream.
In gfs2_glock_poke, make sure gfs2_holder_uninit is called on the local
glock holder. Without that, we're leaking a glock and a pid reference.
Fixes: 9e8990dea926 ("gfs2: Smarter iopen glock waiting")
Cc: stable@xxxxxxxxxxxxxxx # v5.8+
Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/gfs2/glock.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -790,9 +790,11 @@ static void gfs2_glock_poke(struct gfs2_
struct gfs2_holder gh;
int error;
- error = gfs2_glock_nq_init(gl, LM_ST_SHARED, flags, &gh);
+ gfs2_holder_init(gl, LM_ST_SHARED, flags, &gh);
+ error = gfs2_glock_nq(&gh);
if (!error)
gfs2_glock_dq(&gh);
+ gfs2_holder_uninit(&gh);
}
static bool gfs2_try_evict(struct gfs2_glock *gl)
Patches currently in stable-queue which might be from agruenba@xxxxxxxxxx are
queue-5.8/gfs2-fix-refcount-leak-in-gfs2_glock_poke.patch
queue-5.8/gfs2-never-call-gfs2_block_zero_range-with-an-open-transaction.patch
