This is a note to let you know that I've just added the patch titled
remoteproc: qcom: q6v5: Update running state before requesting stop
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
remoteproc-qcom-q6v5-update-running-state-before-requesting-stop.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 5b7be880074c73540948f8fc597e0407b98fabfa Mon Sep 17 00:00:00 2001
From: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
Date: Tue, 2 Jun 2020 22:02:56 +0530
Subject: remoteproc: qcom: q6v5: Update running state before requesting stop
From: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
commit 5b7be880074c73540948f8fc597e0407b98fabfa upstream.
Sometimes the stop triggers a watchdog rather than a stop-ack. Update
the running state to false on requesting stop to skip the watchdog
instead.
Error Logs:
$ echo stop > /sys/class/remoteproc/remoteproc0/state
ipa 1e40000.ipa: received modem stopping event
remoteproc-modem: watchdog received: sys_m_smsm_mpss.c:291:APPS force stop
qcom-q6v5-mss 4080000.remoteproc-modem: port failed halt
ipa 1e40000.ipa: received modem offline event
remoteproc0: stopped remote processor 4080000.remoteproc-modem
Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>
Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource handling")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20200602163257.26978-1-sibis@xxxxxxxxxxxxxx
Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/remoteproc/qcom_q6v5.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/remoteproc/qcom_q6v5.c
+++ b/drivers/remoteproc/qcom_q6v5.c
@@ -151,6 +151,8 @@ int qcom_q6v5_request_stop(struct qcom_q
{
int ret;
+ q6v5->running = false;
+
qcom_smem_state_update_bits(q6v5->state,
BIT(q6v5->stop_bit), BIT(q6v5->stop_bit));
Patches currently in stable-queue which might be from sibis@xxxxxxxxxxxxxx are
queue-5.4/remoteproc-qcom_q6v5_mss-validate-modem-blob-firmware-size-before-load.patch
queue-5.4/remoteproc-qcom_q6v5_mss-validate-mba-firmware-size-before-load.patch
queue-5.4/remoteproc-qcom-q6v5-update-running-state-before-requesting-stop.patch
