This is a note to let you know that I've just added the patch titled
net_sched: sch_skbprio: add message validation to skbprio_change()
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net_sched-sch_skbprio-add-message-validation-to-skbprio_change.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Tue 12 May 2020 10:57:53 AM CEST
From: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Sat, 2 May 2020 20:09:25 -0700
Subject: net_sched: sch_skbprio: add message validation to skbprio_change()
From: Eric Dumazet <edumazet@xxxxxxxxxx>
[ Upstream commit 2761121af87de45951989a0adada917837d8fa82 ]
Do not assume the attribute has the right size.
Fixes: aea5f654e6b7 ("net/sched: add skbprio scheduler")
Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Reported-by: syzbot <syzkaller@xxxxxxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/sched/sch_skbprio.c | 3 +++
1 file changed, 3 insertions(+)
--- a/net/sched/sch_skbprio.c
+++ b/net/sched/sch_skbprio.c
@@ -173,6 +173,9 @@ static int skbprio_change(struct Qdisc *
{
struct tc_skbprio_qopt *ctl = nla_data(opt);
+ if (opt->nla_len != nla_attr_size(sizeof(*ctl)))
+ return -EINVAL;
+
sch->limit = ctl->limit;
return 0;
}
Patches currently in stable-queue which might be from edumazet@xxxxxxxxxx are
queue-4.19/net_sched-sch_skbprio-add-message-validation-to-skbprio_change.patch
queue-4.19/sch_sfq-validate-silly-quantum-values.patch
queue-4.19/fq_codel-fix-tca_fq_codel_drop_batch_size-sanity-checks.patch
queue-4.19/sch_choke-avoid-potential-panic-in-choke_reset.patch
