This is a note to let you know that I've just added the patch titled clk: gpio: handle error codes for of_clk_get_parent_count() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: clk-gpio-handle-error-codes-for-of_clk_get_parent_count.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 0b2e78865d92e2d70542cb1d4d7af1d4ea0a286d Mon Sep 17 00:00:00 2001 From: Brian Norris <computersforpeace@xxxxxxxxx> Date: Wed, 16 Dec 2015 10:35:03 -0800 Subject: clk: gpio: handle error codes for of_clk_get_parent_count() From: Brian Norris <computersforpeace@xxxxxxxxx> commit 0b2e78865d92e2d70542cb1d4d7af1d4ea0a286d upstream. We might make bad memory allocations if we get (e.g.) -ENOSYS from of_clk_get_parent_count(). Noticed by Coverity. Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()") Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> Cc: Jyri Sarha <jsarha@xxxxxx> Cc: Sergej Sawazki <ce3a@xxxxxx> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> Signed-off-by: Michael Turquette <mturquette@xxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/clk/clk-gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/clk/clk-gpio.c +++ b/drivers/clk/clk-gpio.c @@ -287,12 +287,14 @@ static void __init of_gpio_clk_setup(str const char **parent_names; int i, num_parents; + num_parents = of_clk_get_parent_count(node); + if (num_parents < 0) + return; + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) return; - num_parents = of_clk_get_parent_count(node); - parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL); if (!parent_names) return; Patches currently in stable-queue which might be from computersforpeace@xxxxxxxxx are queue-4.4/mtd-nand-pxa3xx_nand-fix-dmaengine-initialization.patch queue-4.4/mtd-nand-fix-onfi-parameter-page-layout.patch queue-4.4/clk-gpio-handle-error-codes-for-of_clk_get_parent_count.patch queue-4.4/mtd-nand-denali-add-missing-nand_release-call-in-denali_remove.patch queue-4.4/firmware-actually-return-null-on-failed-request_firmware_nowait.patch