Patch "um: ensure `make ARCH=um mrproper` removes arch/$(SUBARCH)/include/generated/" has been added to the 5.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    um: ensure `make ARCH=um mrproper` removes arch/$(SUBARCH)/include/generated/

to the 5.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     um-ensure-make-arch-um-mrproper-removes-arch-subarch.patch
and it can be found in the queue-5.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit d74ec709304788dc9f0abae956771115d1775f8b
Author: Vitor Massaru Iha <vitor@xxxxxxxxxxx>
Date:   Tue Apr 21 21:48:44 2020 -0300

    um: ensure `make ARCH=um mrproper` removes arch/$(SUBARCH)/include/generated/
    
    commit 63ec90f18204f2fe072df108de8a021b28b1b173 upstream.
    
    In this workflow:
    
    $ make ARCH=um defconfig && make ARCH=um -j8
      [snip]
    $ make ARCH=um mrproper
      [snip]
    $ make ARCH=um defconfig O=./build_um && make ARCH=um -j8 O=./build_um
      [snip]
      CC      scripts/mod/empty.o
    In file included from ../include/linux/types.h:6,
                     from ../include/linux/mod_devicetable.h:12,
                     from ../scripts/mod/devicetable-offsets.c:3:
    ../include/uapi/linux/types.h:5:10: fatal error: asm/types.h: No such file or directory
        5 | #include <asm/types.h>
          |          ^~~~~~~~~~~~~
    compilation terminated.
    make[2]: *** [../scripts/Makefile.build:100: scripts/mod/devicetable-offsets.s] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [/home/iha/sdb/opensource/lkmp/linux-kselftest.git/Makefile:1140: prepare0] Error 2
    make[1]: Leaving directory '/home/iha/sdb/opensource/lkmp/linux-kselftest.git/build_um'
    make: *** [Makefile:180: sub-make] Error 2
    
    The cause of the error was because arch/$(SUBARCH)/include/generated files
    weren't properly cleaned by `make ARCH=um mrproper`.
    
    Fixes: a788b2ed81ab ("kbuild: check arch/$(SRCARCH)/include/generated before out-of-tree build")
    Reported-by: Theodore Ts'o <tytso@xxxxxxx>
    Suggested-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
    Signed-off-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx>
    Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
    Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
    Link: https://groups.google.com/forum/#!msg/kunit-dev/QmA27YEgEgI/hvS1kiz2CwAJ
    Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

diff --git a/arch/um/Makefile b/arch/um/Makefile
index d2daa206872da..275f5ffdf6f0a 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -140,6 +140,7 @@ export CFLAGS_vmlinux := $(LINK-y) $(LINK_WRAPS) $(LD_FLAGS_CMDLINE)
 # When cleaning we don't include .config, so we don't include
 # TT or skas makefiles and don't clean skas_ptregs.h.
 CLEAN_FILES += linux x.i gmon.out
+MRPROPER_DIRS += arch/$(SUBARCH)/include/generated
 
 archclean:
 	@find . \( -name '*.bb' -o -name '*.bbg' -o -name '*.da' \



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux