Patch "block: remove the bd_openers checks in blk_drop_partitions" has been added to the 5.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    block: remove the bd_openers checks in blk_drop_partitions

to the 5.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     block-remove-the-bd_openers-checks-in-blk_drop_parti.patch
and it can be found in the queue-5.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 88a16caef8c24d5ae826aeed46b86f39b937c34c
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Tue Apr 28 10:52:03 2020 +0200

    block: remove the bd_openers checks in blk_drop_partitions
    
    commit 10c70d95c0f2f9a6f52d0e33243d2877370cef51 upstream.
    
    When replacing the bd_super check with a bd_openers I followed a logical
    conclusion, which turns out to be utterly wrong.  When a block device has
    bd_super sets it has a mount file system on it (although not every
    mounted file system sets bd_super), but that also implies it doesn't even
    have partitions to start with.
    
    So instead of trying to come up with a logical check for all openers,
    just remove the check entirely.
    
    Fixes: d3ef5536274f ("block: fix busy device checking in blk_drop_partitions")
    Fixes: cb6b771b05c3 ("block: fix busy device checking in blk_drop_partitions again")
    Reported-by: Michal Koutný <mkoutny@xxxxxxxx>
    Reported-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxxxxx>
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

diff --git a/block/partition-generic.c b/block/partition-generic.c
index ebe4c2e9834bd..8a7906fa96fd6 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -468,7 +468,7 @@ int blk_drop_partitions(struct gendisk *disk, struct block_device *bdev)
 
 	if (!disk_part_scan_enabled(disk))
 		return 0;
-	if (bdev->bd_part_count || bdev->bd_openers > 1)
+	if (bdev->bd_part_count)
 		return -EBUSY;
 	res = invalidate_partition(disk, 0);
 	if (res)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux