This is a note to let you know that I've just added the patch titled net: freescale: fec: Fix ethtool -d runtime PM to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: net-freescale-fec-fix-ethtool-d-runtime-pm.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From foo@baz Sat 11 Jan 2020 09:13:20 AM CET From: Andrew Lunn <andrew@xxxxxxx> Date: Thu, 2 Jan 2020 15:33:34 +0100 Subject: net: freescale: fec: Fix ethtool -d runtime PM From: Andrew Lunn <andrew@xxxxxxx> [ Upstream commit c72a0bc0aa19f49160330a65ab77184b5b7d131b ] In order to dump the FECs registers the clocks have to be ticking, otherwise a data abort occurs. Add calls to runtime PM so they are enabled and later disabled. Fixes: e8fcfcd5684a ("net: fec: optimize the clock management to save power") Reported-by: Chris Healy <Chris.Healy@xxxxxxxx> Signed-off-by: Andrew Lunn <andrew@xxxxxxx> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/ethernet/freescale/fec_main.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2199,8 +2199,14 @@ static void fec_enet_get_regs(struct net { struct fec_enet_private *fep = netdev_priv(ndev); u32 __iomem *theregs = (u32 __iomem *)fep->hwp; + struct device *dev = &fep->pdev->dev; u32 *buf = (u32 *)regbuf; u32 i, off; + int ret; + + ret = pm_runtime_get_sync(dev); + if (ret < 0) + return; regs->version = fec_enet_register_version; @@ -2216,6 +2222,9 @@ static void fec_enet_get_regs(struct net off >>= 2; buf[off] = readl(&theregs[off]); } + + pm_runtime_mark_last_busy(dev); + pm_runtime_put_autosuspend(dev); } static int fec_enet_get_ts_info(struct net_device *ndev, Patches currently in stable-queue which might be from andrew@xxxxxxx are queue-5.4/net-dsa-mv88e6xxx-force-cmode-write-on-6141-6341.patch queue-5.4/net-freescale-fec-fix-ethtool-d-runtime-pm.patch queue-5.4/net-dsa-mv88e6xxx-preserve-priority-when-setting-cpu-port.patch