This is a note to let you know that I've just added the patch titled
ip6_gre: do not confirm neighbor when do pmtu update
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ip6_gre-do-not-confirm-neighbor-when-do-pmtu-update.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Wed 01 Jan 2020 10:36:29 PM CET
From: Hangbin Liu <liuhangbin@xxxxxxxxx>
Date: Sun, 22 Dec 2019 10:51:10 +0800
Subject: ip6_gre: do not confirm neighbor when do pmtu update
From: Hangbin Liu <liuhangbin@xxxxxxxxx>
[ Upstream commit 675d76ad0ad5bf41c9a129772ef0aba8f57ea9a7 ]
When we do ipv6 gre pmtu update, we will also do neigh confirm currently.
This will cause the neigh cache be refreshed and set to REACHABLE before
xmit.
But if the remote mac address changed, e.g. device is deleted and recreated,
we will not able to notice this and still use the old mac address as the neigh
cache is REACHABLE.
Fix this by disable neigh confirm when do pmtu update
v5: No change.
v4: No change.
v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
dst_ops.update_pmtu to control whether we should do neighbor confirm.
Also split the big patch to small ones for each area.
v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.
Reported-by: Jianlin Shi <jishi@xxxxxxxxxx>
Reviewed-by: Guillaume Nault <gnault@xxxxxxxxxx>
Acked-by: David Ahern <dsahern@xxxxxxxxx>
Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/ipv6/ip6_gre.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -1060,7 +1060,7 @@ static netdev_tx_t ip6erspan_tunnel_xmit
/* TooBig packet may have updated dst->dev's mtu */
if (!t->parms.collect_md && dst && dst_mtu(dst) > dst->dev->mtu)
- dst->ops->update_pmtu(dst, NULL, skb, dst->dev->mtu, true);
+ dst->ops->update_pmtu(dst, NULL, skb, dst->dev->mtu, false);
err = ip6_tnl_xmit(skb, dev, dsfield, &fl6, encap_limit, &mtu,
NEXTHDR_GRE);
Patches currently in stable-queue which might be from liuhangbin@xxxxxxxxx are
queue-4.19/sit-do-not-confirm-neighbor-when-do-pmtu-update.patch
queue-4.19/net-dst-add-new-function-skb_dst_update_pmtu_no_confirm.patch
queue-4.19/vti-do-not-confirm-neighbor-when-do-pmtu-update.patch
queue-4.19/net-dst-do-not-confirm-neighbor-for-vxlan-and-geneve-pmtu-update.patch
queue-4.19/gtp-do-not-confirm-neighbor-when-do-pmtu-update.patch
queue-4.19/ip6_gre-do-not-confirm-neighbor-when-do-pmtu-update.patch
queue-4.19/net-add-bool-confirm_neigh-parameter-for-dst_ops.update_pmtu.patch
queue-4.19/tunnel-do-not-confirm-neighbor-when-do-pmtu-update.patch
