This is a note to let you know that I've just added the patch titled
perf strbuf: Remove redundant va_end() in strbuf_addv()
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
perf-strbuf-remove-redundant-va_end-in-strbuf_addv.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 099be748865eece21362aee416c350c0b1ae34df Mon Sep 17 00:00:00 2001
From: Mattias Jacobsson <2pi@xxxxxx>
Date: Sat, 29 Dec 2018 15:17:50 +0100
Subject: perf strbuf: Remove redundant va_end() in strbuf_addv()
From: Mattias Jacobsson <2pi@xxxxxx>
commit 099be748865eece21362aee416c350c0b1ae34df upstream.
Each call to va_copy() should have one, and only one, corresponding call
to va_end(). In strbuf_addv() some code paths result in va_end() getting
called multiple times. Remove the superfluous va_end().
Signed-off-by: Mattias Jacobsson <2pi@xxxxxx>
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Sanskriti Sharma <sansharm@xxxxxxxxxx>
Link: http://lkml.kernel.org/r/20181229141750.16945-1-2pi@xxxxxx
Fixes: ce49d8436cff ("perf strbuf: Match va_{add,copy} with va_end")
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
tools/perf/util/strbuf.c | 1 -
1 file changed, 1 deletion(-)
--- a/tools/perf/util/strbuf.c
+++ b/tools/perf/util/strbuf.c
@@ -109,7 +109,6 @@ static int strbuf_addv(struct strbuf *sb
return ret;
}
len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap_saved);
- va_end(ap_saved);
if (len > strbuf_avail(sb)) {
pr_debug("this should not happen, your vsnprintf is broken");
va_end(ap_saved);
Patches currently in stable-queue which might be from 2pi@xxxxxx are
queue-4.19/perf-strbuf-remove-redundant-va_end-in-strbuf_addv.patch
