Patch "PCI: rpaphp: Don't rely on firmware feature to imply drc-info support" has been added to the 4.19-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    PCI: rpaphp: Don't rely on firmware feature to imply drc-info support

to the 4.19-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pci-rpaphp-don-t-rely-on-firmware-feature-to-imply-d.patch
and it can be found in the queue-4.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 13dea11f7a75cdd78cd936fa7a74ebfe1ce92e34
Author: Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>
Date:   Sun Nov 10 23:21:32 2019 -0600

    PCI: rpaphp: Don't rely on firmware feature to imply drc-info support
    
    [ Upstream commit 52e2b0f16574afd082cff0f0e8567b2d9f68c033 ]
    
    In the event that the partition is migrated to a platform with older
    firmware that doesn't support the ibm,drc-info property the device
    tree is modified to remove the ibm,drc-info property and replace it
    with the older style ibm,drc-* properties for types, names, indexes,
    and power-domains. One of the requirements of the drc-info firmware
    feature is that the client is able to handle both the new property,
    and old style properties at runtime. Therefore we can't rely on the
    firmware feature alone to dictate which property is currently
    present in the device tree.
    
    Fix this short coming by checking explicitly for the ibm,drc-info
    property, and falling back to the older ibm,drc-* properties if it
    doesn't exist.
    
    Signed-off-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>
    Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
    Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/1573449697-5448-6-git-send-email-tyreld@xxxxxxxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c
index f56004243591..ccc6deeb9ccf 100644
--- a/drivers/pci/hotplug/rpaphp_core.c
+++ b/drivers/pci/hotplug/rpaphp_core.c
@@ -275,7 +275,7 @@ int rpaphp_check_drc_props(struct device_node *dn, char *drc_name,
 		return -EINVAL;
 	}
 
-	if (firmware_has_feature(FW_FEATURE_DRC_INFO))
+	if (of_find_property(dn->parent, "ibm,drc-info", NULL))
 		return rpaphp_check_drc_props_v2(dn, drc_name, drc_type,
 						*my_index);
 	else



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux