This is a note to let you know that I've just added the patch titled
rpmsg: glink: Put an extra reference during cleanup
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rpmsg-glink-put-an-extra-reference-during-cleanup.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From b646293e272816dd0719529dcebbd659de0722f7 Mon Sep 17 00:00:00 2001
From: Chris Lew <clew@xxxxxxxxxxxxxx>
Date: Fri, 4 Oct 2019 15:26:59 -0700
Subject: rpmsg: glink: Put an extra reference during cleanup
From: Chris Lew <clew@xxxxxxxxxxxxxx>
commit b646293e272816dd0719529dcebbd659de0722f7 upstream.
In a remote processor crash scenario, there is no guarantee the remote
processor sent close requests before it went into a bad state. Remove
the reference that is normally handled by the close command in the
so channel resources can be released.
Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Cc: stable@xxxxxxxxxxxxxxx
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Signed-off-by: Chris Lew <clew@xxxxxxxxxxxxxx>
Reported-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/rpmsg/qcom_glink_native.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1613,6 +1613,10 @@ void qcom_glink_native_remove(struct qco
idr_for_each_entry(&glink->lcids, channel, cid)
kref_put(&channel->refcount, qcom_glink_channel_release);
+ /* Release any defunct local channels, waiting for close-req */
+ idr_for_each_entry(&glink->rcids, channel, cid)
+ kref_put(&channel->refcount, qcom_glink_channel_release);
+
idr_destroy(&glink->lcids);
idr_destroy(&glink->rcids);
spin_unlock_irqrestore(&glink->idr_lock, flags);
Patches currently in stable-queue which might be from clew@xxxxxxxxxxxxxx are
queue-4.14/rpmsg-glink-fix-rpmsg_register_device-err-handling.patch
queue-4.14/rpmsg-glink-don-t-send-pending-rx_done-during-remove.patch
queue-4.14/rpmsg-glink-fix-reuse-intents-memory-leak-issue.patch
queue-4.14/rpmsg-glink-set-tail-pointer-to-0-at-end-of-fifo.patch
queue-4.14/rpmsg-glink-put-an-extra-reference-during-cleanup.patch
queue-4.14/rpmsg-glink-free-pending-deferred-work-on-remove.patch
