This is a note to let you know that I've just added the patch titled
rpmsg: glink: Fix rpmsg_register_device err handling
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rpmsg-glink-fix-rpmsg_register_device-err-handling.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From f7e714988edaffe6ac578318e99501149b067ba0 Mon Sep 17 00:00:00 2001
From: Chris Lew <clew@xxxxxxxxxxxxxx>
Date: Fri, 4 Oct 2019 15:27:00 -0700
Subject: rpmsg: glink: Fix rpmsg_register_device err handling
From: Chris Lew <clew@xxxxxxxxxxxxxx>
commit f7e714988edaffe6ac578318e99501149b067ba0 upstream.
The device release function is set before registering with rpmsg. If
rpmsg registration fails, the framework will call device_put(), which
invokes the release function. The channel create logic does not need to
free rpdev if rpmsg_register_device() fails and release is called.
Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Cc: stable@xxxxxxxxxxxxxxx
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Signed-off-by: Chris Lew <clew@xxxxxxxxxxxxxx>
Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/rpmsg/qcom_glink_native.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1400,15 +1400,13 @@ static int qcom_glink_rx_open(struct qco
ret = rpmsg_register_device(rpdev);
if (ret)
- goto free_rpdev;
+ goto rcid_remove;
channel->rpdev = rpdev;
}
return 0;
-free_rpdev:
- kfree(rpdev);
rcid_remove:
spin_lock_irqsave(&glink->idr_lock, flags);
idr_remove(&glink->rcids, channel->rcid);
Patches currently in stable-queue which might be from clew@xxxxxxxxxxxxxx are
queue-4.14/rpmsg-glink-fix-rpmsg_register_device-err-handling.patch
queue-4.14/rpmsg-glink-don-t-send-pending-rx_done-during-remove.patch
queue-4.14/rpmsg-glink-fix-reuse-intents-memory-leak-issue.patch
queue-4.14/rpmsg-glink-set-tail-pointer-to-0-at-end-of-fifo.patch
queue-4.14/rpmsg-glink-put-an-extra-reference-during-cleanup.patch
queue-4.14/rpmsg-glink-free-pending-deferred-work-on-remove.patch
