Patch "drm/udl: use drm_gem_object_put_unlocked." has been added to the 5.0-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    drm/udl: use drm_gem_object_put_unlocked.

to the 5.0-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-udl-use-drm_gem_object_put_unlocked.patch
and it can be found in the queue-5.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 36a3f090c9e01f88977e845687d1d268c2d91abd
Author: Dave Airlie <airlied@xxxxxxxxxx>
Date:   Fri Mar 15 11:37:20 2019 +1000

    drm/udl: use drm_gem_object_put_unlocked.
    
    [ Upstream commit 8f3b487685b2acf71b42bb30d68fd9271bec8695 ]
    
    When Daniel removed struct_mutex he didn't fix this call to the unlocked
    variant which is required since we no longer use struct mutex.
    
    This fixes a bunch of:
    WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm]
    Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t>
    CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2
    
    backtraces when you plug in a udl device.
    
    Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage)
    Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
    Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
    Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index d5a23295dd80..bb7b58407039 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
 	*offset = drm_vma_node_offset_addr(&gobj->base.vma_node);
 
 out:
-	drm_gem_object_put(&gobj->base);
+	drm_gem_object_put_unlocked(&gobj->base);
 unlock:
 	mutex_unlock(&udl->gem_lock);
 	return ret;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux