This is a note to let you know that I've just added the patch titled drm/nouveau: Check backlight IDs are >= 0, not > 0 to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-nouveau-check-backlight-ids-are-0-not-0.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From dc854914999d5d52ac1b31740cb0ea8d89d0372e Mon Sep 17 00:00:00 2001 From: Lyude Paul <lyude@xxxxxxxxxx> Date: Thu, 6 Sep 2018 17:43:21 -0400 Subject: drm/nouveau: Check backlight IDs are >= 0, not > 0 From: Lyude Paul <lyude@xxxxxxxxxx> commit dc854914999d5d52ac1b31740cb0ea8d89d0372e upstream. Remember, ida IDs start at 0, not 1! Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx> Reviewed-by: Karol Herbst <kherbst@xxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx Signed-off-by: Ben Skeggs <bskeggs@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c @@ -116,7 +116,7 @@ nv40_backlight_init(struct drm_connector &nv40_bl_ops, &props); if (IS_ERR(bd)) { - if (bl_connector.id > 0) + if (bl_connector.id >= 0) ida_simple_remove(&bl_ida, bl_connector.id); return PTR_ERR(bd); } @@ -249,7 +249,7 @@ nv50_backlight_init(struct drm_connector nv_encoder, ops, &props); if (IS_ERR(bd)) { - if (bl_connector.id > 0) + if (bl_connector.id >= 0) ida_simple_remove(&bl_ida, bl_connector.id); return PTR_ERR(bd); } Patches currently in stable-queue which might be from lyude@xxxxxxxxxx are queue-4.19/drm-atomic_helper-disallow-new-modesets-on-unregistered-connectors.patch queue-4.19/drm-i915-fix-hpd-handling-for-pins-with-two-encoders.patch queue-4.19/drm-i915-dp-restrict-link-retrain-workaround-to-external-monitors.patch queue-4.19/drm-nouveau-fix-nv50_mstc-best_encoder.patch queue-4.19/drm-i915-skip-vcpi-allocation-for-mstb-ports-that-are-gone.patch queue-4.19/drm-amdgpu-suppress-keypresses-from-acpi_video-events.patch queue-4.19/drm-i915-dp-fix-link-retraining-comment-in-intel_dp_long_pulse.patch queue-4.19/drm-i915-don-t-unset-intel_connector-mst_port.patch queue-4.19/drm-i915-fix-possible-race-in-intel_dp_add_mst_connector.patch queue-4.19/drm-nouveau-check-backlight-ids-are-0-not-0.patch queue-4.19/drm-i915-fix-null-deref-when-re-enabling-hpd-irqs-on-systems-with-mst.patch queue-4.19/drm-dp_mst-check-if-primary-mstb-is-null.patch