This is a note to let you know that I've just added the patch titled ext4: avoid possible double brelse() in add_new_gdb() on error path to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ext4-avoid-possible-double-brelse-in-add_new_gdb-on-error-path.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 4f32c38b4662312dd3c5f113d8bdd459887fb773 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o <tytso@xxxxxxx> Date: Tue, 6 Nov 2018 17:18:17 -0500 Subject: ext4: avoid possible double brelse() in add_new_gdb() on error path From: Theodore Ts'o <tytso@xxxxxxx> commit 4f32c38b4662312dd3c5f113d8bdd459887fb773 upstream. Fixes: b40971426a83 ("ext4: add error checking to calls to ...") Reported-by: Vasily Averin <vvs@xxxxxxxxxxxxx> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> Cc: stable@xxxxxxxxxx # 2.6.38 Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/ext4/resize.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -871,6 +871,7 @@ static int add_new_gdb(handle_t *handle, err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh); if (unlikely(err)) { ext4_std_error(sb, err); + iloc.bh = NULL; goto exit_inode; } brelse(dind); Patches currently in stable-queue which might be from tytso@xxxxxxx are queue-4.19/ext4-fix-buffer-leak-in-ext4_expand_extra_isize_ea-on-error-path.patch queue-4.19/ext4-add-missing-brelse-add_new_gdb_meta_bg-s-error-path.patch queue-4.19/ext4-avoid-buffer-leak-in-ext4_orphan_add-after-prior-errors.patch queue-4.19/ext4-missing-bh-check-in-ext4_xattr_inode_write.patch queue-4.19/ext4-avoid-buffer-leak-on-shutdown-in-ext4_mark_iloc_dirty.patch queue-4.19/ext4-release-bs.bh-before-re-using-in-ext4_xattr_block_find.patch queue-4.19/ext4-fix-missing-cleanup-if-ext4_alloc_flex_bg_array-fails-while-resizing.patch queue-4.19/ext4-fix-buffer-leak-in-__ext4_read_dirblock-on-error-path.patch queue-4.19/ext4-fix-possible-inode-leak-in-the-retry-loop-of-ext4_resize_fs.patch queue-4.19/ext4-fix-buffer-leak-in-ext4_xattr_get_block-on-error-path.patch queue-4.19/ext4-fix-possible-leak-of-sbi-s_group_desc_leak-in-error-path.patch queue-4.19/ext4-add-missing-brelse-in-set_flexbg_block_bitmap-s-error-path.patch queue-4.19/ext4-fix-buffer-leak-in-ext4_xattr_move_to_block-on-error-path.patch queue-4.19/ext4-avoid-potential-extra-brelse-in-setup_new_flex_group_blocks.patch queue-4.19/ext4-add-missing-brelse-update_backups-s-error-path.patch queue-4.19/ext4-avoid-possible-double-brelse-in-add_new_gdb-on-error-path.patch queue-4.19/ext4-fix-possible-leak-of-s_journal_flag_rwsem-in-error-path.patch