Incorrect Security Patches against 1.4.8?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The home page says "There are separate patches available against
1.4.8" with a link to
http://squirrelmail.org/patches/1.4.9-security/stable/.  All patches
apply against vanilla 1.4.8 except:

http://squirrelmail.org/patches/1.4.9-security/stable/mime.patch
Chunk #3
@@ -1616,6 +1698,9 @@ function sq_fixstyle($body, $pos, $messa
                     // possible comment
                     if (isset($body{$i+2}) && substr($body,$i,3) == '!--') {
                         $i = strpos($body,'-->',$i+3);
+                        if ($i === false) { // no end comment
+                            $i = strlen($body);
+                        }
                         $sToken = '';
                     }
                 } else {

This section and comment does not exist at all in 1.4.8, but it does
appear to be in 1.4.9a.  mime2.patch contains the same chunk.  Were
those two patches formed in error?

I am just confirming that I will entirely solve the known issues when
I apply these patches against squirrelmail-1.4.8.

Thank you,
Warren Togami
wtogami@xxxxxxxxxx

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
--
squirrelmail-users mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

[Index of Archives]     [Video For Linux]     [Yosemite News]     [Yosemite Photos]     [gtk]     [KDE]     [Cyrus SASL]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux