On 04/07/18 11:18, Marcus Kool wrote: > I read the changes and like them. > FYI: if you have a github account you should be able to post an approve/change review, aka vote for the PR merge bot. > I also looked at the error messages that Squid produces when helpers are > overloaded. > It would be nice if in external_acl.cc, helper.cc and redirect.cc the > debugs( ... DBG_IMPORTANT ... ) messages have additional text like > #children, concurrency or queue-size may need adjustment > > Thanks > Marcus > > On 03/07/18 17:50, Alex Rousskov wrote: >> On 07/03/2018 10:52 AM, Marcus Kool wrote: >> >>> I do like to see better documentation for the new queue-size option. >>> Including your one-liner in squid.conf.documented is enough for me. >> >> I wish it were that simple! For starters, there are at least six >> independent and slightly different contexts where this queuing should be >> documented. >> >> Please proof read: https://github.com/squid-cache/squid/pull/238 >> >> Alex. >> Amos _______________________________________________ squid-users mailing list squid-users@xxxxxxxxxxxxxxxxxxxxx http://lists.squid-cache.org/listinfo/squid-users
