On Thu, 26 Apr 2007, Adrian Chadd wrote:
Change:
xmemcpy(p, buf, len);
to be:
if (errflag == 0) {
assert(len >= 0);
xmemcpy(p, buf, len);
}
That should stop the crashes but it won't stop the IO errors and I'm not
quite sure whether COSS will return crap to the client request or not.
COSS should at least return a read failure back up to Squid and I'm
sure things will be fine from there.
Let me know if that stops the crashes and I'll go and commit a patch.
It does stop the crashes, but I'm getting a lot of errors, so of which
appear to be new ones:
2007/04/26 15:12:17| COSS: /dev/amrd1: Rebuild Completed
2007/04/26 15:12:17| 81219 objects scanned, 144 objects relocated, 555
objects fresher, 9346 objects ignored
2007/04/26 15:12:18| Completed Validation Procedure
2007/04/26 15:12:18| Validated 143160 Entries
2007/04/26 15:12:18| store_swap_size = 2576724k
2007/04/26 15:12:19| storeLateRelease: released 4996 objects
2007/04/26 15:12:21| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:29| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:29| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:29| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:29| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:36| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:38| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:12:39| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:18| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:31| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:31| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:32| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:33| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:13:41| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:14:23| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:14:35| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:14:35| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:00| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:24| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:33| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:45| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:45| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:56| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:57| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:15:57| squidaio_queue_request: WARNING - Queue congestion
2007/04/26 15:16:04| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:07| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:08| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:14| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/product_styles.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/print.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/aa_homepage_styles.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/tools.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/leftNav.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/css/topnav.css'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/javascript/metafaqs.js'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/images/topnav/mainlogo.gif'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/images/common/bg_body.png'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/images/topnav/meta_faq_button.gif'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| ctx: enter level 0:
'http://www.theaa.com/touchclarity/logging.js'
2007/04/26 15:16:19| WARNING: failed to unpack meta data
2007/04/26 15:16:19| ctx: exit level 0
2007/04/26 15:16:19| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/touchclarity/logging-code.js'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
2007/04/26 15:16:20| ctx: exit level 0
2007/04/26 15:16:20| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/touchclarity/optimise.js'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
2007/04/26 15:16:20| ctx: exit level 0
2007/04/26 15:16:20| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| storeCossCompletePendingReloc: got failure (-1)
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/touchclarity/logging.html'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
2007/04/26 15:16:20| ctx: exit level 0
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/images/homepage/travel/travel_newsflash_title.gif'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
2007/04/26 15:16:20| ctx: exit level 0
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/images/homepage/travel/travel_newflash_button.gif'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
2007/04/26 15:16:20| ctx: exit level 0
2007/04/26 15:16:20| ctx: enter level 0:
'http://www.theaa.com/images/homepage/travel/travel_newflash_bg.jpg'
2007/04/26 15:16:20| WARNING: failed to unpack meta data
Cheers.
--
Mark Powell - UNIX System Administrator - The University of Salford
Information Services Division, Clifford Whitworth Building,
Salford University, Manchester, M5 4WT, UK.
Tel: +44 161 295 4837 Fax: +44 161 295 5888 www.pgp.com for PGP key
