Hello,
The following error message appeared when I applied the latest custom_log
patch to Squid 2.5 12 Stable:
patching file access_log.c
patching file cache_cf.c
Hunk #2 succeeded at 2627 (offset -6 lines).
patching file cf.data.pre
patching file client_side.c
Hunk #1 succeeded at 868 (offset -3 lines).
Hunk #2 succeeded at 889 (offset -3 lines).
Hunk #3 succeeded at 910 (offset -3 lines).
Hunk #4 FAILED at 2038.
Hunk #5 FAILED at 2072.
2 out of 5 hunks FAILED -- saving rejects to file client_side.c.rej patching
file icp_v2.c patching file logfile.c patching file protos.h patching file
structs.h Hunk #3 succeeded at 623 (offset -1 lines).
Hunk #4 succeeded at 1062 (offset -1 lines).
Hunk #5 succeeded at 2208 (offset -7 lines).
patching file typedefs.h
Is this something you can reproduce? The "logformat" works but when I use
the acl it doesn't log anything, this is what I use:
acl logHTML rep_mime_type text/html
logformat combined <standard combined stuff here> access_log
/var/log/squid/access.log combined logHTML
Thank you,
David
But just tested this here and rep_mime_type did not work in access_log,
never matched anything. This has been corrected in the CVS branch and should
get publised as a new patch in a few hours. Please note that the updated
patch is relative to current Squid-2.5 (what will become
2.5.STABLE13) and won't apply to 2.5.STABLE12.
The fix to the old patch is simply to add the following line
http->acl_checklist->reply = http->al.reply;
just before the following line in client_side.c:
if (!Config.accessList.log || aclCheckFast(Config.accessList.log,
http->acl_checklist)) {
Regards
Henrik
