Re: delay pools and ident access lists.

[Henrik Nordstrom <hno@xxxxxxxxxxxxxxx>]

On Fri, 14 Oct 2005, Oleg Sharoiko wrote:

> Hello!
>
> Could you please review the following patch, which solves the problem for
> me. Do I have to fill PR ?

Yes, please file a bug report.

> diff -ur squid-2.5.STABLE11/src/delay_pools.c squid-2.5.STABLE11.patched/src/delay_pools.c
> --- squid-2.5.STABLE11/src/delay_pools.c	Sun Sep 11 05:49:53 2005
> +++ squid-2.5.STABLE11.patched/src/delay_pools.c	Fri Oct 14 11:28:31 2005
> @@ -323,6 +323,7 @@
>     ch.my_port = r->my_port;
>     ch.conn = http->conn;
>     ch.request = r;
> +    xstrncpy(ch.rfc931, http->conn->rfc931, USER_IDENT_SZ);
>     if (r->client_addr.s_addr == INADDR_BROADCAST) {
> 	debug(77, 2) ("delayClient: WARNING: Called with 'allones' address, ignoring\n");
> 	return delayId(0, 0);


Looks fine for delay_access, but I'd rather fix it in a similar manner in 
acl.c making the fix also apply to other acl driven directives.

Regards
Henrik