Re: [PATCH] drm/qxl: Pin buffer objects for internal mappings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 08.07.24 um 13:55 schrieb Dmitry Osipenko:
On 7/2/24 17:20, Thomas Zimmermann wrote:
@@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
  	if (r)
  		return r;
+ r = qxl_bo_pin_locked(bo);
+	if (r)
+		return r;
Is qxl_bo_unreserve() missing here?

Yeah, indeed. Thanks for reporting.

Best regards
Thomas


+
  	r = qxl_bo_vmap_locked(bo, map);
+	if (r)
+		qxl_bo_unpin_locked(bo);
  	qxl_bo_unreserve(bo);
  	return r;

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]