Re: [PATCH spice-common] build: Avoid Meson warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Frediano,

On Fri, Nov 3, 2023 at 10:59 AM Frediano Ziglio <freddy77@xxxxxxxxx> wrote:

WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also:

Signed-off-by: Frediano Ziglio <freddy77@xxxxxxxxx>

Acked-by: Uri Lublin <uril@xxxxxxxxxx>

From a quick scan of the git repositories, there is a 'check' missing in usbredir too.


--- | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ b/
index 1018769..33f8f8a 100644
--- a/
+++ b/
@@ -132,7 +132,7 @@ if spice_common_generate_client_code or spice_common_generate_server_code
   if get_option('python-checks')
     foreach module : ['six', 'pyparsing']
       message('Checking for python module @0@'.format(module))
-      cmd = run_command(python, '-c', 'import @0@'.format(module))
+      cmd = run_command(python, '-c', 'import @0@'.format(module), check : false)
       if cmd.returncode() != 0
         error('Python module @0@ not found'.format(module))

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]