> On Feb 4, 2021, at 2:06 PM, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > Hi Tong > >> I have posted an updated patch. >> The new patch use the following logic >> + if (!qdev->ddev.mode_config.funcs) >> + return; > > This is again just papering over the issue. Better don't call qxl_drm_release() in the error path if qxl_device_init() fails. > > I see two solutions: either roll-back manually, or use our new managed DRM interfaces. This is what the other drivers do. > > Best regards > Thomas IMHO - qdev->ddev.mode_config.funcs is set only if the initialization is successful, so using this as an indicator of error case looks ok to me. The other two options you suggested would require some serious significant amount of work to be done, which I don’t think I currently have such ability to do. Thanks, - Tong _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel