Re: Is it a possible memory leak (spice-gtk/src/channel-display.c)?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi all, for the latest commit in 'spice-gtk/src/channel-display.c', in the
> static function
> 'create_canvas', the first returning point (line 997) and the 'if
> (surface->primary)' (line 1036)
> is not taken then the second returning point, the allocated memory for
> surface would be lost.

> All the calling site store surface on the stack.

> Can anyone confirm this?

> --
> Best Regards

> Ding Fei
> E-mail: danix800@xxxxxxxxx

Indeed, you should g_free(surface).

OT: And apparently format is not used any more.

Frediano 

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]