Hi,
if I remember I think the main issue is that these buttons are kind of wild west.
Basically what is button 6 (first 5 are well defined) ? It can be anything so it could
be that for instance my client left becomes right on the guest.
Maybe just changing mouse model the semantic of the buttons on the guest change.
Also I remember that GTK had some problems, these buttons are not defined, I think
they are passed from the underlying system (Windows, X11, Wayland).
However I see two "workaround":
1- let the users take care of the mismatch. Either getting used to use a button
instead of the other or using some tools;
2- add a message to communicate the meaning of the various buttons (which can
change for instance changing mouse).
I think 1 is what was implemented by the patches, I'd go for this way.
I hope softwares are not associating button semantics to computer shutdown
or something "dangerous" like this.
Frediano
On Tue, May 12, 2020 at 11:58 PM <bruts@xxxxxxx> wrote:Hi Victor,Yes it was certainly a good read and i got some ideas from it, but the code has changed quite a lot since 2017 and the patches correspond to the current code only for about 10-15%.Maybe someone from the Spice team can suggest a patch to add additional mouse buttons - i am sure that it would be a matter of minutes to an hour for anyone who is involved with coding the spice-vdagent project to create a general patch idea to add additional mouse buttonsHello,I'll give it a try this morning, indeed it shouldn't require (much|any) new code, only flags here and there. Let's seeKevinIt is just a matter of forwarding them to the guest - for some reason it was decided not to add them.thanks!De : Victor Toso <victortoso@xxxxxxxxxx>_______________________________________________
À : bruts@xxxxxxx
Sujet : Re: spice-vdagent: how to enable additional mouse buttons?
Date : 12/05/2020 07:25:59 Europe/Paris
Copie à : uril@xxxxxxxxxx;
spice-devel@xxxxxxxxxxxxxxxxxxxxx
Hi,
On Tue, May 12, 2020 at 12:53:02AM +0200, bruts@xxxxxxx wrote:
>
>
> Uri (and others),
>
> I found the similar question in a few corners of the internet
> and I think adding at least the additional default mouse
> buttons should not be all that much work.
You can take a look at this proposal to adding horizontal wheel
support to Spice
https://lists.freedesktop.org/archives/spice-devel/2017-October/040558.html
> With some guidance I could probably do it myself, though the
> guidance would need to be quite substantial :)
>
> The mouse and the main buttons is already forwarded and that is
> the main part.
>
> with xev it is clear to see which buttons work on the host, but
> not on the guest.
>
> Anyone with some spare time (which I know is always limited for
> everyone), but help me where to fix this in the code and i will
> write a patch - or give me a good start - or start yourself.
>
> a semi working mouse in the guest is very annoying and can be
> one of the critical points why to use spice (or not) - at least
> i know it is in my case.
>
> Thanks!!
Cheers,
Victor
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel