Hi Keiichi, On Dienstag, 17. März 2020 07:53:26 CET Keiichi Watanabe wrote: > > > diff --git a/include/uapi/linux/virtio_video.h > > > b/include/uapi/linux/virtio_video.h new file mode 100644 > > > index 000000000000..0dd98a2237c6 > > > --- /dev/null > > > +++ b/include/uapi/linux/virtio_video.h > > > @@ -0,0 +1,469 @@ > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > I suspect it's not expected to use GPL licence without exceptions in a > > UAPI header file: > > https://www.kernel.org/doc/html/v5.4/process/license-rules.html > > > > If GPL is used here, only GPL user programs can include this header > > file, can't they? > > So, can we use BSD licence like other virtio headers (e.g. virtio_gpu.h)? > > > > Note that I found this program when running > > /scripts/headers_install.sh. Though it suggested to add "WITH > > Linux-syscall-note", it shouldn't be the case because this header > > doesn't provide syscall interface. > > > > Best regards, > > Keiichi > > > > > +/* > > > + * Virtio Video Device > > > + * > > > + * This header is BSD licensed so anyone can use the definitions > > > + * to implement compatible drivers/servers: > > > + * > > Ah, this line says this header is BSD licensed. > So, the SPDX-License-Identifier above should be simply wrong. > According to some recent upstream discussion about virtio-snd, which was also proposed by our engineers, it should be /* SPDX-License-Identifier: BSD-3-Clause */ Best regards, Dmitry. > Best regards, > Keiichi _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel