>
> Hi,
>
> On Mon, Oct 07, 2019 at 11:39:01AM +0100, Frediano Ziglio wrote:
> > "name" parameter of smartcard_channel_client_add_reader it's not
> > used.
> >
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
>
> I guess it was used for debugging?
>
As far as I can see was never used since the initial commit.
> Acked-by: Victor Toso <victortoso@xxxxxxxxxx>
>
> > ---
> > server/smartcard-channel-client.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/smartcard-channel-client.c
> > b/server/smartcard-channel-client.c
> > index 0b8644c7..08af49df 100644
> > --- a/server/smartcard-channel-client.c
> > +++ b/server/smartcard-channel-client.c
> > @@ -219,8 +219,7 @@ static void
> > smartcard_channel_client_push_error(RedChannelClient *rcc,
> > red_channel_client_pipe_add_push(rcc, &error_item->base);
> > }
> >
> > -static void smartcard_channel_client_add_reader(SmartCardChannelClient
> > *scc,
> > - uint8_t *name)
> > +static void smartcard_channel_client_add_reader(SmartCardChannelClient
> > *scc)
> > {
> > if (!scc->priv->smartcard) { /* we already tried to attach a reader to
> > the client
> > when it connected */
> > @@ -288,7 +287,7 @@ bool
> > smartcard_channel_client_handle_message(RedChannelClient *rcc,
> > spice_assert(size == vheader->length + sizeof(VSCMsgHeader));
> > switch (vheader->type) {
> > case VSC_ReaderAdd:
> > - smartcard_channel_client_add_reader(scc, msg +
> > sizeof(VSCMsgHeader));
> > + smartcard_channel_client_add_reader(scc);
> > return TRUE;
> > break;
> > case VSC_ReaderRemove:
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel