>
> Signed-off-by: Snir Sheriber <ssheribe@xxxxxxxxxx>
> ---
>
> This helps to debug plugins load related issues
Why this is not in the commit message? Which kind of issues (this too
would be fine in the commit message) ?
> ---
> src/channel-display-gst.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index 437328b..16bfa37 100644
> --- a/src/channel-display-gst.c
> +++ b/src/channel-display-gst.c
> @@ -473,6 +473,10 @@ sink_event_probe(GstPad *pad, GstPadProbeInfo *info,
> gpointer data)
> static void
> element_setup_cb(GstElement *pipeline, GstElement *element, SpiceGstDecoder
> *decoder)
> {
> + GstElementFactory *f = gst_element_get_factory (element);
Style: space after function name.
> +
> + SPICE_DEBUG("A new element was added to Gstreamer's pipeline (%s)",
> + f ? GST_OBJECT_NAME(f) : GST_OBJECT_NAME(element));
Why just not GST_OBJECT_NAME(element) ? Or always element name and factory
one if available ?
> /* Attach a probe to the sink to update the statistics */
> if (GST_IS_BASE_SINK(element)) {
> GstPad *pad = gst_element_get_static_pad(element, "sink");
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel